Fields are pub; once Hotshot tag 0.5.12 is out, will update type #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinI
requested changes
Feb 6, 2024
| offered_fee: u64, | ||
| pub block_hash: BlockHash<I>, | ||
| pub block_size: u64, | ||
| pub offered_fee: u64, | ||
| _phantom: PhantomData<I>, |
There was a problem hiding this comment.
This either needs to be pub as well, or there needs to be a constructor method
There was a problem hiding this comment.
Added a constructor...
There was a problem hiding this comment.
We'll want to replace this block_metadata when merging in @move47's branch, but this one fixes the CI, so it might be nice to get it in.
|
I think we can close this PR as well as I merged the one with more recent changes @nyospe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.