Initial api design #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyospe
reviewed
Mar 12, 2024
There was a problem hiding this comment.
Is this just the bare API definition? The next step will be to set up the service loop? Specifically, we know the point of this is to run the hotshot_handle.get_event_stream() loop and push the events to all of the API subscribers.
Anyway, it looks like a good start. Get the clippy issues fixed, and we can merge, and continue from there.
Cargo.toml
Outdated
| @@ -1,5 +1,5 @@ | |||
| [package] | |||
| name = "hs-builder-api" | |||
| name = "hotshot-events-service" | |||
| version = "0.1.1" | |||
There was a problem hiding this comment.
Let's start this at "0.1.0"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the bare minimum API specs to receive events from Hotshot.