New apis integration #43
Conversation
|
Closes #18 |
src/builder_state.rs
Outdated
| <<TYPES as BuilderType>::SignatureKey as SignatureKey>::PureAssembledSignatureType, | ||
| pub sender: TYPES::SignatureKey, | ||
| pub metadata: <<TYPES as NodeType>::BlockPayload as BlockPayload>::Metadata, | ||
| pub join_handle: Arc<JoinHandle<<VidScheme as VidSchemeTrait>::Commit>>, |
There was a problem hiding this comment.
couldn't this just be Arc<JoinHandle<vid::VidCommitment>>?
src/builder_state.rs
Outdated
| // convert vid_num_nodes to usize | ||
| // spawn a task to calculate the VID commitment, and pass the builder handle to the global state | ||
| // later global state can await on it before replying to the proposer | ||
| let join_handle: JoinHandle<<VidScheme as VidSchemeTrait>::Commit> = |
There was a problem hiding this comment.
This shouldn't need to be explicitly typed...
src/service.rs
Outdated
| pub tx_sender: BroadcastSender<MessageType<Types>>, | ||
|
|
||
| // sending a DA proposal from the hotshot to the builder states | ||
| pub da_sender: BroadcastSender<MessageType<Types>>, |
There was a problem hiding this comment.
Why do we have these, other than the tx_sender?
There was a problem hiding this comment.
Since global state implements hotshot events stream service aka run_standalone_builder_service now. Should we take hotshot events stream service out from global state and keep it as separate function as earlier?
There was a problem hiding this comment.
It will also help in spawning a task based on this standalone function.
There was a problem hiding this comment.
But we need tx_sender in the Global State to implement submit_txn for txn submit api.
To accomodate new changes in
hs-builder-api.claim_block_header_inputapi.cliam_block_header_input. It sort of replaces the earliervid_desperssalhandle.