Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

Fix potential sleep with lock #243

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Fix potential sleep with lock #243

merged 1 commit into from
Aug 20, 2024
+5 −6

Conversation

shenkeyao
Copy link
Member

Closes #242.

This PR:

  • Breaks the while loop if the builder is found, to avoid lock due to sleep.

Ayiga
Ayiga approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@Ayiga Ayiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@shenkeyao shenkeyao merged commit adf440c into main Aug 20, 2024
5 checks passed
@shenkeyao shenkeyao deleted the keyao/fix-lock branch August 20, 2024 00:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ayiga Ayiga Ayiga approved these changes

@jbearer jbearer Awaiting requested review from jbearer

@QuentinI QuentinI Awaiting requested review from QuentinI

Assignees

@jbearer jbearer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix potential sleep with lock
3 participants
@shenkeyao @Ayiga @jbearer