Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

Do not call payload.num_transactions() #210

Closed
wants to merge 1 commit into from

Conversation

lukaszrzasik
Copy link
Contributor

Closes #<ISSUE_NUMBER>

This PR:

This PR just substitutes a call to payload.num_transactions() with self.tx_queue.len() which gives the same results.
payload.num_transactions() looks deceptively harmless but the implementation in Payload is very cpu heavy.
I see big performance improvement with just this change.

This PR does not:

Unfortunately does not fix the current builder issues. Builder works visibly faster but is still very cpu-heavy and the sequencer times out waiting for the blocks.

Key places to review:

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Lukasz Rzasik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lukaszrzasik lukaszrzasik deleted the lr/optimise-txn-count branch July 19, 2024 10:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants