This repository has been archived by the owner on Dec 3, 2024. It is now read-only.
Give BlockBuilder time to register; fix same block duplicate txns regression #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbearer
approved these changes
Jun 28, 2024
nyospe
added a commit
to EspressoSystems/espresso-sequencer
that referenced
this pull request
Jul 2, 2024
Fixes timing of flawed unit test, revealed by EspressoSystems/hotshot-builder-core#196 ### This PR: Changes a wait from 3 seconds to half a second, to avoid a timing failure on a unit test ### This PR does not: Do anything else of significance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #194
Closes #195
This PR:
See here: https://espresso.zulipchat.com/#narrow/stream/419229-Testnet-V5-.28Cappuccino.29/topic/Builder.20Changes.2FUpgrades.2FBugfixes/near/447823430