This repository has been archived by the owner on Dec 3, 2024. It is now read-only.
GC included txns #152
Merged
GC included txns #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyospe
reviewed
May 22, 2024
src/builder_state.rs
Outdated
| txn_info.remove_entry(); | ||
| } | ||
| }); | ||
|
|
||
| // clear the txns from included txns which are older than current timestamp by 3 secs |
There was a problem hiding this comment.
What? No. I meant, we could clear after... days? Hours, maybe, at the smallest increment.
There was a problem hiding this comment.
We can do 2 hours. But... maybe let's try this instead: https://espresso.zulipchat.com/#narrow/stream/419378-Block-Builder/topic/Staging.20performance.20issues/near/440153803 with the <unit of time> configurable, defaulting to 1 hour.
nyospe
suggested changes
May 23, 2024
| next_txn_garbage_collect_time = | ||
| self.next_txn_garbage_collect_time + self.txn_garbage_collect_duration; | ||
| } | ||
|
|
There was a problem hiding this comment.
More idiomatic as:
let (included_txns, included_txns_old, included_txns_expiring, next_txn_garbage_collect_time) = if Instant::now() >= self.next_txn_garbage_collect_time {
(HashSet::new(), self.included_txns.clone(), self.included_txns_old.clone(), Instant::now() + self.txn_garbage_collect_duration)
} else {
(self.included_txns.clone(), self.included_txns_old.clone(), self.included_txns_expiring.clone(), self. next_txn_garbage_collect_time)
};
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #151