Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: hotshot 0.5.83 #2417

Draft
wants to merge 16 commits into
base: ab/st
Choose a base branch
from
Draft

WIP: hotshot 0.5.83 #2417

wants to merge 16 commits into from

Conversation

sveitser
Copy link
Collaborator

@sveitser sveitser commented Dec 19, 2024 •
edited
Loading

Note this PR is currently into branch ab/st not into main.

  • Make rustc happy.
  • cargo check passes
  • cargo check --tests passes

TODO

  • implement migrate_consensus

@sveitser
WIP: hotshot 0.5.83
53131fb 
- Make rustc happy.
- Still contains some todo!.
- `cargo check` passes
- `cargo check --tests` fails, needs a fix in query service
@sveitser sveitser mentioned this pull request Dec 19, 2024
Draft
1 task
@sveitser
Update hotshot-query-service
721698a 
Tests also compile now (with some holes in builder initialization)
sveitser
sveitser commented Dec 19, 2024
View reviewed changes
sequencer/src/lib.rs Outdated Show resolved Hide resolved
sveitser and others added 3 commits December 19, 2024 14:12
@sveitser
fix double space
87e146b
@QuentinI
Builder changes
1e2fd09
@sveitser
cargo: remove patch
60f1427 
Since we have a crate that depends on the main workspace now the cargo
patches don't affect it and compilation fails as a result.
sveitser
sveitser commented Dec 19, 2024
View reviewed changes
types/src/v0/traits.rs Outdated Show resolved Hide resolved
tbro and others added 11 commits December 19, 2024 17:36
@tbro
add --keep-going to lint
88aca4f
@tbro
Pull in updates from hotshot
6bf3060 
Run `cargo update` and add some fixes for recent updates. We need
`add_epoch_root()` on `Memberships` trait to fix this.
@tbro
fix compile errors for the Memberships trait update
1c47fda
@imabdulbasit
store next epoch qc
0fa1f3f
@imabdulbasit
Merge branch 'ma/hotshot-0.5.83' into ab/store-next-epoch-qc
5da92ff
@imabdulbasit
update query service
b9338c2
@sveitser
Update hotshot-* dependencies
688aedc
@sveitser
Fix rust compilation
9385491
@imabdulbasit
store next epoch qc in persistence (#2422)
bd74fe5 
Hotshot now has a new function update_next_epoch_high_qc2() in its
storage trait to update the next epoch qc in persistence. This PR adds
storage for this quorum certificate and also loads it when loading the
consensus data,
@imabdulbasit
Merge branch 'ab/st' into ma/hotshot-0.5.83
6a6be1a
@sveitser
cargo fmt
4eaf8f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imabdulbasit imabdulbasit imabdulbasit left review comments

@philippecamacho philippecamacho Awaiting requested review from philippecamacho philippecamacho will be requested when the pull request is marked ready for review philippecamacho is a code owner

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe will be requested when the pull request is marked ready for review ImJeremyHe is a code owner

@jbearer jbearer Awaiting requested review from jbearer jbearer will be requested when the pull request is marked ready for review jbearer is a code owner

@tbro tbro Awaiting requested review from tbro tbro will be requested when the pull request is marked ready for review tbro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sveitser @imabdulbasit @QuentinI @tbro