Add from_bytes method.
#2329
Merged
Add from_bytes method.
#2329
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #2327
tbro
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
imabdulbasit
as code owners
tbro
requested review from
ImJeremyHe and
mrain
and removed request for
ImJeremyHe
mrain
approved these changes
Nov 25, 2024
mrain
reviewed
Nov 25, 2024
| @@ -100,6 +100,13 @@ impl NsTable { | |||
| self.len().in_bounds(index) | |||
| } | |||
|
|
|||
| /// Instantiate an `NsTable` from a byte slice. | |||
| pub fn from_bytes(bytes: &[u8]) -> NsTable { | |||
There was a problem hiding this comment.
nit: maybe call it from_bytes_unchecked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2327
Adds
from_bytesmethod toNsTableto facilitate nitro development (see issue).