Reconnect L1 WS stream if disconnected #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbearer
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
tbro and
imabdulbasit
as code owners
types/src/v0/impls/l1.rs
Outdated
| }) | ||
| } | ||
|
|
||
| async fn stop(&self) { |
There was a problem hiding this comment.
It seems like this only stops the reconnect functionality, but the L1 connection is still reachable. Maybe it should be renamed to something more appropriate
There was a problem hiding this comment.
Yeah it stops all the background tasks (the reconnect task and the snapshot updating task). Ideally this would take self by value and just destroy the whole client but it's not easy to implement like that because L1 client is behind an Arc in NodeState.
Maybe like shut_down_tasks, and also rename start to spawn_tasks?
Ethers internally tries to reconnect once, but if that fails, it gives up and shuts down the whole provider backend. This is not good in the case of extended outages of the L1 server. This change handles errors from the underlying RPC client indicating that the connection is closed by spawning a task to reestablish the connection. This task tries until it succceeds.
jbearer
force-pushed
the
jb/ws-reconnect
branch
from
380c01c to
d4388a0
Compare
imabdulbasit
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ethers internally tries to reconnect once, but if that fails, it gives up and shuts down the whole provider backend. This is not good in the case of extended outages of the L1 server.
This PR:
Key places to review:
RpcClient::requestRpcClient::drop,L1Client::stopThings tested
New regression tests fail before this change