Add pipefail to docker demo #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sveitser
reviewed
Nov 7, 2024
.github/workflows/build.yml
Outdated
| @@ -478,7 +478,7 @@ jobs: | |||
| labels: ${{ steps.dev-rollup.outputs.labels }} | |||
|
|
|||
| test-demo: | |||
| if: ${{ github.event_name != 'pull_request' }} | |||
There was a problem hiding this comment.
I think you can also use workflow dispatch to trigger it even though it has this if statement. Not 100% sure though.
sveitser
approved these changes
Nov 7, 2024
temporarily disable !pull_request filter
tbro
force-pushed
the
tb/ci/false-positive-docker-demo
branch
from
e0ceea5 to
c046b44
Compare
tbro
requested review from
philippecamacho,
ImJeremyHe,
jbearer and
imabdulbasit
as code owners
tbro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker demo is succeeding on main, even though services never become ready. The error in the logs is:
example run: https://github.com/EspressoSystems/espresso-sequencer/actions/runs/11706340826/job/32604796112
In addition, !pull_request filter has been temporarily removed so we can reproduce in this PR.