Arity is already available as an associated constant. #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it is slightly better if we always access the associated constant instead of duplicating it into a stand alone constant as well as the associated one.
tbro
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
imabdulbasit
as code owners
sveitser
reviewed
Nov 6, 2024
types/src/v0/v0_1/state.rs
Outdated
| @@ -15,12 +15,11 @@ use std::collections::HashSet; | |||
| pub type BlockMerkleTree = LightWeightSHA3MerkleTree<Commitment<Header>>; | |||
| pub type BlockMerkleCommitment = <BlockMerkleTree as MerkleTreeScheme>::Commitment; | |||
|
|
|||
| pub type FeeMerkleTree = UniversalMerkleTree<FeeAmount, Sha3Digest, FeeAccount, FEE_MERKLE_TREE_ARITY, Sha3Node>; | |||
| pub type FeeMerkleTree = UniversalMerkleTree<FeeAmount, Sha3Digest, FeeAccount, 256, Sha3Node>; | |||
There was a problem hiding this comment.
I think now it's harder to know what the 256 is for if you just look the code outside an editor. I think it would be fine to keep the constant just for that. Could make it not pub though, or just put a comment /* arity */
sveitser
approved these changes
Nov 6, 2024
imabdulbasit
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is slightly better if we always access the associated constant instead of duplicating it into a stand-alone constant in addition to the associated one.