Accept WebSockets provider for fee contract proxy check #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbearer
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
tbro and
imabdulbasit
as code owners
imabdulbasit
approved these changes
Nov 5, 2024
sveitser
reviewed
Nov 7, 2024
| @@ -37,6 +37,7 @@ ESPRESSO_SEQUENCER_GENESIS_FILE=/genesis/demo.toml | |||
| ESPRESSO_SEQUENCER_L1_PORT=8545 | |||
| ESPRESSO_SEQUENCER_L1_WS_PORT=8546 | |||
| ESPRESSO_SEQUENCER_L1_PROVIDER=http://demo-l1-network:${ESPRESSO_SEQUENCER_L1_PORT} | |||
| ESPRESSO_SEQUENCER_L1_WS_PROVIDER=http://demo-l1-network:${ESPRESSO_SEQUENCER_L1_WS_PORT} | |||
There was a problem hiding this comment.
@jbearer is this http:// on purpose?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the new WebSockets functionality for the L1 client is unusable, because the sequencer takes the same
ESPRESSO_SEQUENCER_L1_PROVIDERURL and passes it to a client that only accepts HTTP, for the fee contract proxy check.This PR:
L1Client(which accepts HTTP or WS) instead of `Provider1