[WEEKLY RELEASE] HotShot - rc-0.5.79 #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion trait (#2222) Closes EspressoSystems/marketplace-builder-core#169 <!-- These comments should help create a useful PR message, please delete any remaining comments before opening the PR. --> <!-- If there is no issue number make sure to describe clearly *why* this PR is necessary. --> <!-- Mention open questions, remaining TODOs, if any --> ### This PR: - implement the trait for Transaction defined in sequencer, substitute all places calculating tx size to the use of this function - changes are together with Hotshot changes: EspressoSystems/HotShot#3800 Builder changes: EspressoSystems/marketplace-builder-core#202 <!-- Describe what this PR adds to this repo and why --> <!-- E.g. --> <!-- * Implements feature 1 --> <!-- * Fixes bug 3 --> ### This PR does not: <!-- Describe what is out of scope for this PR, if applicable. Leave this section blank if it's not applicable --> <!-- This section helps avoid the reviewer having to needlessly point out missing parts --> <!-- * Implement feature 3 because that feature is blocked by Issue 4 --> <!-- * Implement xyz because that is tracked in issue #123. --> <!-- * Address xzy for which I opened issue #456 --> ### Key places to review: <!-- Describe key places for reviewers to pay close attention to --> <!-- * file.rs, `add_integers` function --> <!-- Or directly comment on those files/lines to make it easier for the reviewers --> <!-- ### How to test this PR: --> <!-- Optional, uncomment the above line if this is relevant to your PR --> <!-- If your PR is fully tested through CI there is no need to add this section --> <!-- * E.g. `just test` --> <!-- ### Things tested --> <!-- Anything that was manually tested (that is not tested in CI). --> <!-- E.g. building/running of docker containers. Changes to docker demo, ... --> <!-- Especially mention anything untested, with reasoning and link an issue to resolve this. --> <!-- Complete the following items before creating this PR --> <!-- [ ] Issue linked or PR description mentions why this change is necessary. --> <!-- [ ] PR description is clear enough for reviewers. --> <!-- [ ] Documentation for changes (additions) has been updated (added). --> <!-- [ ] If this is a draft it is marked as "draft". --> <!-- To make changes to this template edit https://github.com/EspressoSystems/.github/blob/main/PULL_REQUEST_TEMPLATE.md -->
dailinsubjam
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer,
tbro and
imabdulbasit
as code owners
tbro
reviewed
Oct 30, 2024
Cargo.toml
Outdated
| hotshot-stake-table = { git = "https://github.com/EspressoSystems/hotshot", tag = "0.5.78-patch4" } | ||
| hotshot-builder-api = { git = "https://github.com/EspressoSystems/HotShot.git", branch = "bump/rc-0.5.79" } | ||
| hotshot-builder-core = { git = "https://github.com/EspressoSystems/marketplace-builder-core", branch = "hotshot/rc-0.5.79" } | ||
| marketplace-builder-core = { git = "https://github.com/EspressoSystems/marketplace-builder-core", branch = "hotshot/rc-0.5.79" } |
There was a problem hiding this comment.
Looks good. Only question: should we move these from branch to tag before we merge?
There was a problem hiding this comment.
Yes! I'll update them after weekly release PR are merged in other repos.
|
let's try to fix the Slow Test. Something is clogging it. I understand it's annoying to wait for 40min to merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
This PR does not:
Key places to review: