Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code #2199

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Remove dead code #2199

merged 4 commits into from
Oct 23, 2024

Conversation

jbearer
Copy link
Member

@jbearer jbearer commented Oct 22, 2024

Delete some dead code. This stuff hasn't been used in ages, might as well speed up build and test times a little.

This PR:

  • Removes the HotShot contract, commitment task, and related ops code

@jbearer jbearer force-pushed the jb/delete-commitment-task branch from a0edda5 to 1f8cadf Compare October 22, 2024 18:45
@sveitser sveitser linked an issue Oct 23, 2024 that may be closed by this pull request
- Rename the env var of the prover service port to
  ESPRESSO_PROVER_SERVICE_PORT that's actually used by the service.
Copy link
Collaborator

@sveitser sveitser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just found some more occurrences and deleted those.

The 8 cpu runner has 12 GB of RAM, this doesn't always seem to be enough
to compile and we sometimes get sigkills. Use the next larger runner
with 24 GB of RAM.
@sveitser sveitser merged commit 01d22d6 into main Oct 23, 2024
17 checks passed
@sveitser sveitser deleted the jb/delete-commitment-task branch October 23, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove (mock) hotshot contract, commitment task
2 participants