Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct PlonkVerifier in deployer.rs #2173

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

alxiong
Copy link
Contributor

@alxiong alxiong commented Oct 15, 2024

separate the part of the changes originally included in #2148

This PR:

  • Switch to the right version of PlonkVerifier (in the deployer.rs we incorrectly deployed PlonkVerifier2.sol which is secure but less efficient)

@alxiong
Copy link
Contributor Author

alxiong commented Oct 15, 2024

let's get this uncontested logic backported to release-gambit first, the gas oracle logic can take longer. @jbearer @sveitser

@jbearer jbearer merged commit 7e16992 into main Oct 15, 2024
13 checks passed
@jbearer jbearer deleted the gambit-pv-patch branch October 15, 2024 13:32
Copy link
Contributor

Backport failed for release-gambit, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-gambit
git worktree add -d .worktree/backport-2173-to-release-gambit origin/release-gambit
cd .worktree/backport-2173-to-release-gambit
git switch --create backport-2173-to-release-gambit
git cherry-pick -x d5e423cf30272cd75728f713fee0416e16ed65fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants