improve dev build times for everyone #2133
Merged
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbro
requested review from
philippecamacho,
ImJeremyHe and
sveitser
as code owners
ss-es
reviewed
Oct 8, 2024
Cargo.toml
Outdated
| @@ -156,3 +156,12 @@ hotshot-testing ={ git = "https://www.github.com/EspressoSystems/HotShot.git", t | |||
| hotshot-types = { git = "https://www.github.com/EspressoSystems/HotShot.git", tag = "0.5.75-patch1" } | |||
| libp2p-networking = { git = "https://github.com/EspressoSystems//HotShot.git", tag = "0.5.75-patch1" } | |||
| hotshot-example-types = { git = "https://www.github.com/EspressoSystems/HotShot.git", tag = "0.5.75-patch1" } | |||
|
|
|||
| [profile.dev] | |||
| opt-level = 1 | |||
There was a problem hiding this comment.
Is there a reason not to set this (and the other one) to just opt-level = 0?
There was a problem hiding this comment.
I don't remember why I set it to 1.
| # Skip compiling the debug information in the first place. | ||
| debug = 0 | ||
| # Skip linking debug information. | ||
| strip = "debuginfo" |
There was a problem hiding this comment.
is there a reason not to just do strip = true? (I don't actually know how significant this is)
There was a problem hiding this comment.
I know that we don't want debuginfo. I'm not sure if we want symbols or not.
tbro
force-pushed
the
tb/build/dev-profile
branch
from
f329bdf to
494709b
Compare
tbro
force-pushed
the
tb/build/dev-profile
branch
from
287a180 to
9bc30e7
Compare
sveitser
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds dev profile to
Cargo.toml. It improves build times considerably. I don't think it hurts anything. So probably ok if CI passes. Feel free to run some cargo commands to see how you like it.