[WEEKLY RELEASE] HotShot - rc-0.5.77 #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss-es
reviewed
Oct 4, 2024
imabdulbasit
reviewed
Oct 7, 2024
lukeiannucci
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
tbro
as code owners
sveitser
reviewed
Oct 8, 2024
sveitser
reviewed
Oct 8, 2024
sveitser
reviewed
Oct 8, 2024
| )) | ||
| } | ||
|
|
||
| async fn store_upgrade_certificate( |
There was a problem hiding this comment.
I think we should add some tests for this:
- to verify that storing and loading works
- to verify that we store at most 1 upgrade certificate
- to verify that cleanup works
@imabdulbasit can you advise @lukeiannucci on how to add these tests.
imabdulbasit
reviewed
Oct 8, 2024
imabdulbasit
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weekly Release
This PR:
Weekly merge include:
1.) File changes for the Vote Commitment for UTs to pass (see #2111)
2.) Libp2p refactoring
3.) Adding table to store upgrade certificate that hotshot is able to load after a restart. Add a test to ensure we can store/load the upgrade certificate.
This PR does not:
Key places to review: