1706 improve versioning for the light client contract #1800
Conversation
alysiahuggins
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser,
jbearer,
tbro and
imabdulbasit
as code owners
alysiahuggins
changed the title
| ); | ||
| } | ||
|
|
||
| // that the data remains the same after upgrading the implementation |
There was a problem hiding this comment.
nit: test that the data remains the same after upgrading the implementation
There was a problem hiding this comment.
sorted here 7c3569c
| assertEq(lcV1Proxy.frozenThreshold(), stateV1.threshold); | ||
| } | ||
|
|
||
| // that the data remains the same after upgrading the implementation |
There was a problem hiding this comment.
nit: test that the data remains the same after upgrading the implementation
There was a problem hiding this comment.
sorted here 7c3569c
| @@ -0,0 +1,194 @@ | |||
| # Smart Contract Upgrades | |||
|
|
|||
| Code on the EVM is immutable but via proxies, smart contracts can be “upgraded”. A proxy contract acts as an | |||
There was a problem hiding this comment.
I think the documentation should be little more specific to our contracts - the _Example:_ section should have an example of how one should proceed if they need to upgrade LightClient.sol. Otherwise I think, this becomes general documentation about smart contract upgradeability which can be found online. What are your thoughts on the same?
There was a problem hiding this comment.
fair point, i'll add more info specific to LightClient.sol
There was a problem hiding this comment.
sorted in this commit and previous commits 105e26a
…initialization in new implementations of an upgradable contract
alysiahuggins
deleted the
1706-improve-versioning-for-the-light-client-contract
branch
Closes #1706
This PR:
virtualkeyword was added to functions in the LightClient contract so that they can be overridden in future versions of its implementationThis PR does not:
Key places to review:
How to test this PR:
forge test --match-contract LightClientUpgradeToV2Testjust sol-testThings tested
To Do