Add skeleton types types for auctions #1472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm probably going off on a limb, but its easier for me to think about the types if there is some logic tying them together. Ultimately I think we will expose a function to an event handler that will make the gears turn. I believe `ViewNumber` can be passed in, and I'm guessing `BidTx` we be as well.
tbro
reviewed
May 16, 2024
| // - needs to be configured in genesis block | ||
| // - needs to be updatable | ||
| /// Configuration for the auction system | ||
| struct AuctionConfig { |
There was a problem hiding this comment.
I can see in a very generic way why we need this information, but I'm having trouble reasoning about how we will actually use it. I feel like we will need to receive an event announcing the start of a phase. And from there we can use this to calculate the view at which that phase will end. Are there indeterminate spans between phases? if the end of one phase == start of next then we would only need the start of the first phase on the chain, which could just be a constant (or come from config).
tbro
reviewed
May 17, 2024
| fn recv_bid(&self, view: ViewNumber, bid: BidTx) { | ||
| self.update(view); | ||
| match self.phase.kind { | ||
| AuctionPhaseKind::Bid => self.send_txn(bid.as_txn()), |
There was a problem hiding this comment.
Rereading, I think the actions that will actually occur are validation and persistence.
tbro
reviewed
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1471
TODO
This PR:
This is a very early sketch based on the notion document for discussion and experimentation.
This PR does not:
Implement anything.