Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restartability #1354

Merged
merged 13 commits into from
Apr 23, 2024
Merged

Restartability #1354

merged 13 commits into from
Apr 23, 2024

Conversation

jbearer
Copy link
Member

@jbearer jbearer commented Apr 22, 2024

No description provided.

jbearer added 11 commits April 22, 2024 08:40
* Track anchor leaf and high QC together: the QC must always be
  the QC corresponding to the anchor leaf, it isn't necessarily the
  highest QC we've ever seen
* Implement validated state loading from storage on restart
* Fix bug with index in `remember_blocks_merkle_tree`
* When getting fee Merkle paths to update stored state, take the
  proof from either `LookupResult::Ok` or `LookupResult::NotFound`.
  Do not `expect_ok`, as this will not work for non-membership proofs
@jbearer jbearer marked this pull request as ready for review April 23, 2024 15:12
@jbearer
Copy link
Member Author

jbearer commented Apr 23, 2024

check-edits failure is because I added the state API to the native demo, but it was already present in the docker demo

Copy link
Contributor

@philippecamacho philippecamacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbearer jbearer merged commit cd08419 into main Apr 23, 2024
15 of 16 checks passed
@jbearer jbearer deleted the jb/restart branch April 23, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants