Add builder Dockerfile #1305
Merged
Add builder Dockerfile #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update docker-compose and friends
tbro
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser and
jbearer
as code owners
|
Could you add it to |
Also fix Dockerfile wrong name.
This reverts commit ec87fb5.
sveitser
reviewed
Apr 9, 2024
sveitser
reviewed
Apr 9, 2024
sveitser
reviewed
Apr 9, 2024
| depends_on: | ||
| sequencer0: | ||
| condition: process_healthy | ||
| da_server: |
There was a problem hiding this comment.
Is there a reason this doesn't have the condition?
There was a problem hiding this comment.
I wasn't sure what it could be, and it wasn't the most urgent issue at this time.
|
@tbro Does the builder work for you in process compose and the docker demo? It looks like the necessary env vars are not set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docker-compose and friends. Build in CI.