[Sequencer] New network integration #1294
Conversation
| let cdn_network = PushCdnNetwork::new( | ||
| network_params.cdn_endpoint, | ||
| vec!["Global".into(), "DA".into()], | ||
| KeyPair { | ||
| public_key: WrappedSignatureKey(my_config.public_key), | ||
| private_key: my_config.private_key.clone(), | ||
| }, | ||
| ) | ||
| .await | ||
| .with_context(|| "Failed to create CDN network")?; |
There was a problem hiding this comment.
I have in-progress CDN changes to make the initial connection be lazily initialized, but they aren't in yet.
rob-maron
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser and
jbearer
as code owners
| /// The user-facing address to advertise | ||
| #[arg( | ||
| long, | ||
| default_value = "local_ip:1738", |
There was a problem hiding this comment.
Took a brief look at the push cdn code. So local_ip is a magic value that will be resolved to a local IP? What will it choose if there are multiple network interfaces? Would we ever not want this to be set to local_ip?
There was a problem hiding this comment.
Yessir, downstream it is resolved to whatever local_ip::local_ip_address() returns. I made it like this so it's easier to specify it if it's unknown and not set (e.g. in AWS).
If there are multiple networking interfaces, my thought is to use 0.0.0.0 to bind to all of them. For example, we would want it (public_advertise_address specifically) to be 0.0.0.0 on a fully public deployment that does not use load balancers
|
cc @imabdulbasit for builder-related changes |
Closes #1299
This PR:
TL;DR: Updates the sequencer to use the combined network (Libp2p and Push CDN).
Specifically: