only store if certificate is provided

sequencer/src/persistence.rs

@@ -497,10 +497,10 @@ mod persistence_tests {
             Default::default(),
             Default::default(),
         );
-        storage
+        let res = storage
             .store_upgrade_certificate(Some(decide_upgrade_certificate.clone()))
-            .await
-            .unwrap();
+            .await;
+        assert!(res.is_ok());
 
         let res = storage.load_upgrade_certificate().await.unwrap();
         let view_number = res.unwrap().view_number;
@@ -510,6 +510,11 @@ mod persistence_tests {
         let mut new_upgrade_certificate = decide_upgrade_certificate.clone();
         new_upgrade_certificate.view_number = new_view_number_for_certificate;
 
+        let res = storage
+            .store_upgrade_certificate(Some(new_upgrade_certificate.clone()))
+            .await;
+        assert!(res.is_ok());
+
         let res = storage.load_upgrade_certificate().await.unwrap();
         let view_number = res.unwrap().view_number;
         assert_eq!(view_number, new_view_number_for_certificate);

sequencer/src/persistence/fs.rs

@@ -723,15 +723,19 @@ impl SequencerPersistence for Persistence {
     ) -> anyhow::Result<()> {
         let mut inner = self.inner.write().await;
         let path = &inner.upgrade_certificate_dir_path();
+        let certificate = match decided_upgrade_certificate {
+            Some(cert) => cert,
+            None => return Ok(()),
+        };
         inner.replace(
             path,
             |_| {
                 // Always overwrite the previous file.
                 Ok(true)
             },
             |mut file| {
-                let bytes = bincode::serialize(&decided_upgrade_certificate)
-                    .context("serializing upgrade certificate")?;
+                let bytes =
+                    bincode::serialize(&certificate).context("serializing upgrade certificate")?;
                 file.write_all(&bytes)?;
                 Ok(())
             },

sequencer/src/persistence/sql.rs

@@ -569,8 +569,12 @@ impl SequencerPersistence for Persistence {
         &self,
         decided_upgrade_certificate: Option<UpgradeCertificate<SeqTypes>>,
     ) -> anyhow::Result<()> {
-        let upgrade_certificate_bytes = bincode::serialize(&decided_upgrade_certificate)
-            .context("serializing upgrade certificate")?;
+        let certificate = match decided_upgrade_certificate {
+            Some(cert) => cert,
+            None => return Ok(()),
+        };
+        let upgrade_certificate_bytes =
+            bincode::serialize(&certificate).context("serializing upgrade certificate")?;
         let mut tx = self.db.write().await?;
         tx.upsert(
             "upgrade_certificate",