Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos in documentation files #3947

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/macros/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ use syn::{
/// description of a crosstest
#[derive(derive_builder::Builder, Debug, Clone)]
struct CrossTestData {
/// imlementations
/// implementations
impls: ExprArray,
/// builder impl
#[builder(default = "syn::parse_str(\"[SimpleBuilderImplementation]\").unwrap()")]
Expand Down
2 changes: 1 addition & 1 deletion crates/orchestrator/api.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Supply whether or not we are DA.
[route.peer_pubconfig_ready]
PATH = ["peer_pub_ready"]
DOC = """
Get whether the node can collect the final config which includs all peer's public config/info like public keys, returns a boolean.
Get whether the node can collect the final config which includes all peer's public config/info like public keys, returns a boolean.
"""

# POST the updated config with all peers' public keys / configs
Expand Down
2 changes: 1 addition & 1 deletion crates/testing/src/block_builder/simple.rs
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ where
.await;

if transactions.is_empty() {
// We don't want to return an empty block if we have no trasnactions, as we would end up
// We don't want to return an empty block if we have no transactions, as we would end up
// driving consensus to produce empty blocks extremely quickly when mempool is empty.
// Instead, we return no blocks, so that view leader will keep asking for blocks until
// either we have something non-trivial to propose, or leader runs out of time to propose,
Expand Down
2 changes: 1 addition & 1 deletion crates/types/src/simple_vote.rs
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ impl<TYPES: NodeType> Committable for ViewSyncCommitData<TYPES> {
}
}

// impl votable for all the data types in this file sealed marker should ensure nothing is accidently
// impl votable for all the data types in this file sealed marker should ensure nothing is accidentally
// implemented for structs that aren't "voteable"
impl<V: sealed::Sealed + Committable + Clone + Serialize + Debug + PartialEq + Hash + Eq> Voteable
for V
Expand Down
2 changes: 1 addition & 1 deletion docs/diagrams/HotShotFlow.drawio
Original file line number Diff line number Diff line change
Expand Up @@ -1937,7 +1937,7 @@
<mxCell id="2Nz8MQJxElo4916phK1H-1" value="Are all events for the same view?&amp;nbsp;" style="whiteSpace=wrap;html=1;rounded=0;fillColor=#dae8fc;strokeColor=#6c8ebf;strokeWidth=2;" vertex="1" parent="1">
<mxGeometry x="90" y="740" width="120" height="60" as="geometry" />
</mxCell>
<mxCell id="2Nz8MQJxElo4916phK1H-3" value="Events are not for the same veiw" style="whiteSpace=wrap;html=1;fillColor=#f8cecc;strokeColor=#b85450;rounded=1;arcSize=50;verticalLabelPosition=bottom;verticalAlign=top;shape=mxgraph.flowchart.or;strokeWidth=6;" vertex="1" parent="1">
<mxCell id="2Nz8MQJxElo4916phK1H-3" value="Events are not for the same view" style="whiteSpace=wrap;html=1;fillColor=#f8cecc;strokeColor=#b85450;rounded=1;arcSize=50;verticalLabelPosition=bottom;verticalAlign=top;shape=mxgraph.flowchart.or;strokeWidth=6;" vertex="1" parent="1">
<mxGeometry x="300" y="740" width="60" height="60" as="geometry" />
</mxCell>
<mxCell id="2Nz8MQJxElo4916phK1H-4" style="edgeStyle=orthogonalEdgeStyle;rounded=0;orthogonalLoop=1;jettySize=auto;html=1;entryX=0;entryY=0.5;entryDx=0;entryDy=0;entryPerimeter=0;" edge="1" parent="1" source="2Nz8MQJxElo4916phK1H-1" target="2Nz8MQJxElo4916phK1H-3">
Expand Down
4 changes: 2 additions & 2 deletions scripts/benchmark_scripts/aws_ecs_benchmarks_cdn_gpu.sh
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ EOF
sleep 30

# start leaders need to run on GPU FIRST
# and WAIT for enough time till it registerred at orchestrator
# and WAIT for enough time till it registered at orchestrator
# make sure you're able to access the remote nvidia gpu server
echo -e "\e[35mGoing to start leaders on remote gpu server $REMOTE_GPU_HOST\e[0m"

Expand Down Expand Up @@ -165,4 +165,4 @@ done
# shut down all related threads
echo -e "\e[35mGoing to stop cdn-marshal\e[0m"
killall -9 cdn-marshal
# for pid in $(ps -ef | grep "keydb-server" | awk '{print $2}'); do sudo kill -9 $pid; done
# for pid in $(ps -ef | grep "keydb-server" | awk '{print $2}'); do sudo kill -9 $pid; done
Loading