Fix the return value of builder transaction status API

[dailinsubjam]

This PR:

• fix the return value of txn stat api
• Related to [Documentation] - Add builder transaction status API to gitbook marketplace-builder-core#264 .

This PR does not:

Key places to review:

[ss-es]

looks good to me

I might be misunderstanding the fix though, doesn't the code still do exactly the same thing as before?

[shenkeyao]

Having the same question as @ss-es about the change. 🤔

[dailinsubjam]

@ss-es @shenkeyao Original code will return Ok(transaction_commit), after the fix it will return Result(TransactionStatus, BuildError). Or am I missing anything?

[ss-es]

Oh sorry, I see - yes you're completely right! It used to return Result<tx.commit(), Error::TxnStat> but now it returns something like Result<state.txn_status, Error::TxnStat>

ignore my comment -- it looks good to me!

[shenkeyao]

@ss-es @shenkeyao Original code will return Ok(transaction_commit), after the fix it will return Result(TransactionStatus, BuildError). Or am I missing anything?

Totally makes sense. 😃