Add randomized Membership impls for testing #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pls148
force-pushed
the
ps/test-randomized-committee
branch
19 times, most recently
from
9adfb1c to
2bb7f99
Compare
pls148
changed the title
pls148
force-pushed
the
ps/test-randomized-committee
branch
2 times, most recently
from
8693058 to
3464b81
Compare
pls148
force-pushed
the
ps/test-randomized-committee
branch
from
3464b81 to
462d05e
Compare
pls148
force-pushed
the
ps/test-randomized-committee
branch
from
8be316a to
3c2b7c5
Compare
pls148
force-pushed
the
ps/test-randomized-committee
branch
3 times, most recently
from
1dc6185 to
6533334
Compare
pls148
force-pushed
the
ps/test-randomized-committee
branch
2 times, most recently
from
4d25a34 to
f190b5c
Compare
lukaszrzasik
approved these changes
Nov 25, 2024
crates/types/src/simple_vote.rs
Outdated
| @@ -24,6 +24,9 @@ use crate::{ | |||
| vote::{HasViewNumber, Vote}, | |||
| }; | |||
|
|
|||
| /// Marker that data should use the quorum cert type | |||
| pub(crate) trait QuorumMaker {} | |||
There was a problem hiding this comment.
typo? Marker vs Maker?
There was a problem hiding this comment.
Not sure if that's a typo, @tbro let me know if it is. I've amended this PR to rename QuorumMaker->QuorumMarker but not positive that's your intent
There was a problem hiding this comment.
I'm not sure either. Just noticed a discrepancy between the trait name and the comment above.
There was a problem hiding this comment.
from context I think it's meant to be QuorumMarker (it looks like it indicates that things need to be signed by the full quorum rather than DA)
pls148
force-pushed
the
ps/test-randomized-committee
branch
from
f190b5c to
44456f9
Compare
Delete Memberships and replace functionality. Add some methods to `Membership` trait to deal w/ collapsing into one type both kinds of memberships (stake and DA). * avoid passing membership into `is_valid_cert * for DA, avoid proxying threshold through `Threshold` trait * remove `Topic` param from `Membership::new * Split cert impls by marker (#3891) * add membership methods to Cert trait * remove non-existent tests from justfile
We can keep the old name where we only have one membership type to keep the diff smaller.
Always use quorum for leader selection
pls148
force-pushed
the
ps/test-randomized-committee
branch
3 times, most recently
from
00e6acd to
ca4e339
Compare
pls148
force-pushed
the
ps/test-randomized-committee
branch
from
ca4e339 to
77a88f1
Compare
ss-es
approved these changes
Dec 2, 2024
Comment on lines
+44
to
+62
| // cross_tests!( | ||
| // TestName: test_epoch_success, | ||
| // Impls: [MemoryImpl, Libp2pImpl, PushCdnImpl], | ||
| // Types: [TestTypes, TestTypesRandomizedLeader, TestTypesRandomizedCommitteeMembers<StableQuorumFilterConfig<123, 2>>, TestTypesRandomizedCommitteeMembers<RandomOverlapQuorumFilterConfig<123, 4, 5, 0, 2>>], | ||
| // Versions: [EpochsTestVersions], | ||
| // Ignore: false, | ||
| // Metadata: { | ||
| // TestDescription { | ||
| // // allow more time to pass in CI | ||
| // completion_task_description: CompletionTaskDescription::TimeBasedCompletionTaskBuilder( | ||
| // TimeBasedCompletionTaskDescription { | ||
| // duration: Duration::from_secs(60), | ||
| // }, | ||
| // ), | ||
| // ..TestDescription::default() | ||
| // } | ||
| // }, | ||
| // ); | ||
|
|
There was a problem hiding this comment.
is this meant to be commented out?
There was a problem hiding this comment.
yep, that's for once the epoch change actually works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3826
This branch has been rebased against another PR (#3867) which introduces a bunch of other changes to Memberships
A separate branch pre-rebase has been saved off here, if that helps with reviewing: https://github.com/EspressoSystems/HotShot/tree/ps/test-randomized-committee-premerge
This PR:
This PR does not:
Key places to review:
The implementations in hotshot/traits/election/helpers.rs, make sure those are commented well enough to be understood
Review the way I'm passing filter configs into TestTypesRandomizedCommitteeMembers (*FilterConfig)
CI