Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seed leader rotation from QC #3743

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Seed leader rotation from QC #3743

wants to merge 8 commits into from

Conversation

ss-es
Copy link
Contributor

@ss-es ss-es commented Oct 9, 2024

This PR:

  • makes leader an async function
  • adds a method add_seed to the Membership trait to add a seed at a given block height
  • adds a new committee type for statically-seeded leader rotation, with the old RandomizedCommittee used for dynamically-seeded leader rotation

This PR does not:

Key places to review:

@ss-es ss-es changed the base branch from main to ss/fallible-leader October 9, 2024 21:38
@ss-es ss-es force-pushed the ss/fallible-leader branch from d23ec22 to f6c3d19 Compare October 16, 2024 18:14
@ss-es ss-es modified the milestones: PoS - DRB, DRB (PoS), Upgrade (PoS) Oct 21, 2024
@ss-es ss-es self-assigned this Oct 22, 2024
Base automatically changed from ss/fallible-leader to main October 23, 2024 16:40
@shenkeyao shenkeyao self-requested a review October 24, 2024 17:09
@shenkeyao shenkeyao self-assigned this Oct 24, 2024
@ss-es ss-es removed this from the DRB (PoS) milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenkeyao shenkeyao Awaiting requested review from shenkeyao

@bfish713 bfish713 Awaiting requested review from bfish713 bfish713 will be requested when the pull request is marked ready for review bfish713 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@shenkeyao shenkeyao

@ss-es ss-es

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ss-es @shenkeyao