Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump async-lock from 2.8.0 to 3.2.0 #2188

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 8, 2023

Bumps async-lock from 2.8.0 to 3.2.0.

Release notes

Sourced from async-lock's releases.

v3.2.0

  • Add missing methods for blocking on locking with types wrapped in Arc (#71).

v3.1.2

  • Bump event-listener to version v4.0.0. (#69)

v3.1.1

  • Add a note to the documentation comparing this crate against libstd's locks. (#58)

v3.1.0

  • Add a Default implementation for OnceCell (#63).

v3.0.0

  • Breaking: Add an enabled-by-default std feature that allows using this crate without the standard library. (#43)
  • Support blocking and non-blocking operations on the same locks. (#56)
  • Switch to a more efficient event notification mechanism. (#43)
Changelog

Sourced from async-lock's changelog.

Version 3.2.0

  • Add missing methods for blocking on locking with types wrapped in Arc (#71).

Version 3.1.2

  • Bump event-listener to version v4.0.0. (#69)

Version 3.1.1

  • Add a note to the documentation comparing this crate against libstd's locks. (#58)

Version 3.1.0

  • Add a Default implementation for OnceCell (#63).

Version 3.0.0

  • Breaking: Add an enabled-by-default std feature that allows using this crate without the standard library. (#43)
  • Support blocking and non-blocking operations on the same locks. (#56)
  • Switch to a more efficient event notification mechanism. (#43)
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from rob-maron as a code owner December 8, 2023 15:18
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust labels Dec 8, 2023
@dependabot dependabot bot force-pushed the dependabot/cargo/async-lock-3.2.0 branch 2 times, most recently from dbc01a2 to dda7d0d Compare December 21, 2023 13:35
Bumps [async-lock](https://github.com/smol-rs/async-lock) from 2.8.0 to 3.2.0.
- [Release notes](https://github.com/smol-rs/async-lock/releases)
- [Changelog](https://github.com/smol-rs/async-lock/blob/master/CHANGELOG.md)
- [Commits](smol-rs/async-lock@v2.8.0...v3.2.0)

---
updated-dependencies:
- dependency-name: async-lock
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/async-lock-3.2.0 branch from dda7d0d to 3736cd4 Compare January 4, 2024 14:16
@DieracDelta
Copy link
Contributor

DieracDelta commented Jan 9, 2024

I think that order to upgrade async-lock, we'll need to bump async-lock in tide disco first. I tried to do this a week ago and the trait name changed (or the trait was moved? not sure). Now when I compile I get:

error[E0277]: the trait bound `async_lock::RwLock<WebServerState<KEY>>: WriteState` is not satisfied
   --> crates/web_server/src/lib.rs:871:15
    |
871 |     let api = define_api(&options).unwrap();
    |               ^^^^^^^^^^ the trait `WriteState` is not implemented for `async_lock::RwLock<WebServerState<KEY>>`
    |
    = help: the following other types implement trait `WriteState`:
              async_lock::mutex::Mutex<State>
              async_lock::rwlock::RwLock<State>
              Arc<W>
              ()
note: required by a bound in `define_api`
   --> crates/web_server/src/lib.rs:682:48
    |
680 | fn define_api<State, KEY>(options: &Options) -> Result<Api<State, Error>, ApiError>
    |    ---------- required by a bound in this function
681 | where
682 |     State: 'static + Send + Sync + ReadState + WriteState,
    |                                                ^^^^^^^^^^ required by this bound in `define_api`

error[E0277]: the trait bound `async_lock::RwLock<OrchestratorState<KEY, ELECTION>>: WriteState` is not satisfied
   --> crates/orchestrator/src/lib.rs:246:15
    |
246 |     let api = define_api().map_err(|_e| io::Error::new(ErrorKind::Other, "Failed to define api"));
    |               ^^^^^^^^^^ the trait `WriteState` is not implemented for `async_lock::RwLock<OrchestratorState<KEY, ELECTION>>`
    |
    = help: the following other types implement trait `WriteState`:
              async_lock::mutex::Mutex<State>
              async_lock::rwlock::RwLock<State>
              Arc<W>
              ()
note: required by a bound in `define_api`
   --> crates/orchestrator/src/lib.rs:194:48
    |
191 | fn define_api<KEY: SignatureKey, ELECTION: ElectionConfig, State>(
    |    ---------- required by a bound in this function
...
194 |     State: 'static + Send + Sync + ReadState + WriteState,
    |                                                ^^^^^^^^^^ required by this bound in `define_api`

@shenkeyao
Copy link
Member

We decided to not fix the CI and close this PR.

@shenkeyao shenkeyao closed this Jan 11, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 11, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/async-lock-3.2.0 branch January 11, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants