-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tech Debt] Allow nodes to rejoin by saving index and config #2168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #2135
This PR:
Allows nodes to rejoin consensus after stopping and dropping off completely.
from_file
andto_file
to theNetworkConfig
implementationfrom_file_or_orchestrator
to the above implementation, which takes an orchestrator client and returns both the configuration and the source (so we don't make theReady
call to the orchestrator every time)OrchestratorClient
codeThere are also some unrelated changes that make running the examples easier.
This PR does not:
Key places to review:
config.rs
- theNetworkConfig
implementationsmod.rs
- for how we use the newNetworkConfig
API in our examples