Add VID to webserver #1954
Merged
Add VID to webserver #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliedavidson
previously approved these changes
Oct 30, 2023
| // vote.current_view, | ||
| // self.committee_exchange.public_key() | ||
| // ); | ||
| debug!("DA vote recv, Main Task {:?}", vote.current_view,); |
| @@ -361,6 +369,9 @@ where | |||
| } | |||
| } | |||
| } | |||
| HotShotEvent::VidCertRecv(_) => { | |||
There was a problem hiding this comment.
I actually think we'd want to put this event into the consensus task, since replicas need to check if they have it before voting on a quorum proposal. But this can be done in a separate issue.
elliedavidson
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes the webserver error per view