Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sishan/validator onboarding #1947

Closed
wants to merge 40 commits into from
Closed

Sishan/validator onboarding #1947

wants to merge 40 commits into from

Conversation

dailinsubjam
Copy link
Contributor

@dailinsubjam dailinsubjam commented Oct 26, 2023 •
edited
Loading

This PR:

  • Added a struct for ValidatorConfigFile and ValidatorConfig.
  • Added a flow from reading config seed of file to generating a node's own key pairs.
  • Make sure key generation only appear in test initialization or config initialization.
  • Added a script to generate key pair for the node. The steps are in Scripts for generating key pair #1971.

Main review parts: orchestrator/src/config.rs, crates/types/src/lib.rs.
Wrapped by #1990.

dailinsubjam and others added 23 commits October 12, 2023 15:47
@dailinsubjam
remove some generated_from_seed_indexed()
134d39a
@dailinsubjam
remove some generated_from_seed_indexed()
21061fe
@dailinsubjam
fix lint
1189edb
@dailinsubjam
solve conflict
45208dc
@dailinsubjam
make the key pair configurable
9a856fe
@dailinsubjam
get keypair and stakevalue from config in modDA.rs
615037b
@dailinsubjam
initialize known_nodes_sk
974357a
@dailinsubjam
generated_from_seed_indexed only appear in initialization or generato…
d3374fe 
…r process
@dailinsubjam
let the stake value be extractable if needed rather than assign 1u64 …
e42635f 
…manually
@dailinsubjam
unwrap() to expect()
41b287f
@dailinsubjam
avoid too many generic type for OrchestratorState
fc81a8b
@dailinsubjam
avoid too many generic type for NetworkConfig
319a336
@dailinsubjam
avoid too many generic type for OrchestratorApi
4a17875
@dailinsubjam
fix lint
eaea764
add validator structure in config.rs
0958125
@dailinsubjam
add validator config with default value
4e4fcbf
@dailinsubjam
simplify hotshot and add node's validator info to hotshotconfig
87c5de6
@dailinsubjam
move validator config from NetworkConfig to HotshotConfigFile
0f97b09
@dailinsubjam
fix lint
c7ea1a3
@dailinsubjam
remove useless comment
f4197f9
@dailinsubjam
merge, but why view number could be 0
dbe6450
@dailinsubjam
cargo update but now the issue is in block_impl.rs called unwrap() on…
8d5c308 
… an Err
@dailinsubjam
solve view number overflow and downgrade to original cargo.lock
992fc67
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dailinsubjam
❌ Sishan Long

Sishan Long seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dailinsubjam dailinsubjam marked this pull request as draft October 26, 2023 18:03
@dailinsubjam dailinsubjam linked an issue Oct 26, 2023 that may be closed by this pull request
Validator Onboarding Macro Task #1739
Closed
4 tasks
@dailinsubjam
add some comments and make sure key generation is only in system init…
362199d 
…ialization or test initialization
@dailinsubjam
Merge pull request #1949 from EspressoSystems/sishan/default_config_p…
7acc7b2 
…eer_validators

set other nodes' default pub key and stake value during initialization
@dailinsubjam
add struct ValidatorConfigFile
2b31188
@dailinsubjam
add validator config file
ac71f6b
@dailinsubjam
Add validator config
440ab12
@dailinsubjam
Merge pull request #1964 from EspressoSystems/sishan/config_file_vali…
3319f38 
…dator

Config file for validator
@dailinsubjam
fix lint
091727c
@dailinsubjam
make config file path configurable
4f1fa04
@dailinsubjam
scripts for generating key pairs added
753f4e5
@dailinsubjam
fix lint
e571008
@dailinsubjam
forget to add new file for validator config
a73c690
@dailinsubjam
blank line at the end of the file
aab444f
@dailinsubjam
Merge pull request #1980 from EspressoSystems/sishan/scripts_gen_keypair
66f5507 
Sishan/scripts gen keypair
@dailinsubjam
Copy link
Contributor Author

Changed the base to sishan/merge_validator_onboarding_after_pull.

@dailinsubjam dailinsubjam deleted the sishan/validator_onboarding branch November 3, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rob-maron rob-maron Awaiting requested review from rob-maron rob-maron will be requested when the pull request is marked ready for review rob-maron is a code owner

@elliedavidson elliedavidson Awaiting requested review from elliedavidson elliedavidson will be requested when the pull request is marked ready for review elliedavidson is a code owner

@bfish713 bfish713 Awaiting requested review from bfish713 bfish713 will be requested when the pull request is marked ready for review bfish713 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validator Onboarding Macro Task
2 participants
@dailinsubjam @CLAassistant