Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update combined network #1863

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Update combined network #1863

merged 3 commits into from
Oct 10, 2023

Conversation

rob-maron
Copy link
Collaborator

Updates the combined network to do the following:

  • adds primary/secondary logic
  • message de-duplication
  • adds tests

no changes since last review except for merge

@rob-maron rob-maron marked this pull request as ready for review October 4, 2023 15:45
@rob-maron rob-maron requested a review from DieracDelta October 4, 2023 15:47
@rob-maron rob-maron changed the title Combined network updates Update combined network Oct 4, 2023
DieracDelta
DieracDelta previously approved these changes Oct 9, 2023
View reviewed changes
@rob-maron rob-maron requested a review from DieracDelta October 10, 2023 13:49
@rob-maron rob-maron merged commit 8308897 into develop Oct 10, 2023
@rob-maron rob-maron deleted the rm/combined-network-updates-m branch October 10, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DieracDelta DieracDelta DieracDelta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rob-maron @DieracDelta