Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick fix: in_flight test nondeterminism #1847

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

rob-maron
Copy link
Collaborator

@rob-maron rob-maron commented Oct 2, 2023

Test was occasionally hanging when using the Tokio runtime

aims to close #1857

@rob-maron rob-maron changed the title fix: in_flight test nondeterminism quick fix: in_flight test nondeterminism Oct 2, 2023
@rob-maron rob-maron marked this pull request as ready for review October 2, 2023 13:40
@rob-maron rob-maron requested a review from ggutoski October 3, 2023 14:59
Copy link
Contributor

@ggutoski ggutoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea how this test works. But the change is tiny and if it fixes the hanging issue then LGTM. Thanks for fixing!

@rob-maron rob-maron merged commit 42d19ba into main Oct 3, 2023
4 checks passed
@rob-maron rob-maron deleted the rm/fix-hanging-test branch October 3, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memory_network_test_in_flight_message_count hangs nondeterministically on main branch
2 participants