Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory network reliability #1844

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Memory network reliability #1844

merged 1 commit into from
Oct 7, 2023

Conversation

DieracDelta
Copy link
Contributor

@DieracDelta DieracDelta commented Oct 1, 2023 •
edited
Loading

Re-enables the network reliability trait and implements it for MemoryNetwork. Closes #1803

rob-maron
rob-maron approved these changes Oct 1, 2023
View reviewed changes
Copy link
Collaborator

@rob-maron rob-maron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! I like the use of delays to introduce latency, and of scramble to introduce corruption. This could be a good way to brute force some of the nondeterminism we've been seeing.

@DieracDelta DieracDelta merged commit 6c34184 into main Oct 7, 2023
4 checks passed
@DieracDelta DieracDelta deleted the jr/network_reliability branch October 7, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rob-maron rob-maron rob-maron approved these changes

@bfish713 bfish713 Awaiting requested review from bfish713 bfish713 is a code owner

@dailinsubjam dailinsubjam Awaiting requested review from dailinsubjam

@shenkeyao shenkeyao Awaiting requested review from shenkeyao

@elliedavidson elliedavidson Awaiting requested review from elliedavidson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement NetworkReliability for MemoryNetwork
2 participants
@DieracDelta @rob-maron