Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update combined network #1826

Closed
wants to merge 27 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
0b68ba7
de-duplicate messages, fix tests, primary/secondary logic
rob-maron Sep 27, 2023
c4fdc8a
fix tests, add sound(er) logic
rob-maron Sep 27, 2023
2806a9f
fmt
rob-maron Sep 27, 2023
7bf1dba
add cache tests
rob-maron Sep 28, 2023
30af640
Merge branch 'main' into rm/combined-network-updates
rob-maron Sep 28, 2023
14ec177
type updates
rob-maron Sep 28, 2023
dee2dbf
Fix transactions (#1825)
rob-maron Sep 28, 2023
7c48e20
Speed up linting by moving it to the build workflow (#1832)
rob-maron Sep 28, 2023
2a15fe5
Bump clap from 4.4.5 to 4.4.6
dependabot[bot] Sep 29, 2023
67be089
Fix/re-enable memory network tests (#1831)
rob-maron Sep 29, 2023
27b0731
fix: revert to using fixed val for transactions (#1835)
rob-maron Sep 29, 2023
35487c2
flake.lock: Update
github-actions[bot] Oct 1, 2023
0f37731
Merge pull request #1840 from EspressoSystems/update_flake_lock_action
DieracDelta Oct 1, 2023
63f7a78
Merge pull request #1833 from EspressoSystems/dependabot/cargo/clap-4…
DieracDelta Oct 1, 2023
a8e2939
PR comments
rob-maron Oct 1, 2023
4d2a9a1
Bump generic-array from 0.14.7 to 1.0.0 (#1724)
dependabot[bot] Oct 2, 2023
a2add78
Bump libp2p-identity from 0.2.3 to 0.2.4
dependabot[bot] Oct 3, 2023
e4595ed
Merge pull request #1856 from EspressoSystems/dependabot/cargo/libp2p…
DieracDelta Oct 3, 2023
42d19ba
fix hanging test (#1847)
rob-maron Oct 3, 2023
a1156b1
de-duplicate messages, fix tests, primary/secondary logic
rob-maron Sep 27, 2023
7703c55
fix tests, add sound(er) logic
rob-maron Sep 27, 2023
fea3b92
fmt
rob-maron Sep 27, 2023
65dbadf
add cache tests
rob-maron Sep 28, 2023
0257838
type updates
rob-maron Sep 28, 2023
c6560e2
PR comments
rob-maron Oct 1, 2023
eb8bd4d
Merge branch 'rm/combined-network-updates' of github.com:EspressoSyst…
rob-maron Oct 4, 2023
a8ef49a
revert merge
rob-maron Oct 4, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions crates/constants/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,12 @@ pub const LOOK_AHEAD: u64 = 5;

/// the default kademlia record republication interval (in seconds)
pub const KAD_DEFAULT_REPUB_INTERVAL_SEC: u64 = 28800;

/// the number of messages to cache in the combined network
pub const COMBINED_NETWORK_CACHE_SIZE: usize = 1000;

/// the number of messages to attempt to send over the primary network before switching to prefer the secondary network
pub const COMBINED_NETWORK_MIN_PRIMARY_FAILURES: u64 = 10;

/// the number of messages to send over the secondary network before re-attempting the (presumed down) primary network
pub const COMBINED_NETWORK_PRIMARY_CHECK_INTERVAL: u64 = 10;
2 changes: 1 addition & 1 deletion crates/hotshot/src/traits.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ pub use storage::{Result as StorageResult, Storage};
pub mod implementations {
pub use super::{
networking::{
combined_network::{CombinedCommChannel, CombinedNetworks},
libp2p_network::{Libp2pCommChannel, Libp2pNetwork, PeerInfoVec},
memory_network::{DummyReliability, MasterMap, MemoryCommChannel, MemoryNetwork},
web_server_libp2p_fallback::{CombinedNetworks, WebServerWithFallbackCommChannel},
web_server_network::{WebCommChannel, WebServerNetwork},
},
storage::memory_storage::MemoryStorage, // atomic_storage::AtomicStorage,
Expand Down
2 changes: 1 addition & 1 deletion crates/hotshot/src/traits/networking.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
//! - [`MemoryNetwork`](memory_network::MemoryNetwork), an in memory testing-only implementation
//! - [`Libp2pNetwork`](libp2p_network::Libp2pNetwork), a production-ready networking impelmentation built on top of libp2p-rs.

pub mod combined_network;
pub mod libp2p_network;
pub mod memory_network;
pub mod web_server_libp2p_fallback;
pub mod web_server_network;

pub use hotshot_types::traits::network::{
Expand Down
Loading