Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transactions #1825

Merged
merged 6 commits into from
Sep 28, 2023
Merged

Fix transactions #1825

merged 6 commits into from
Sep 28, 2023

Conversation

rob-maron
Copy link
Collaborator

@rob-maron rob-maron commented Sep 27, 2023

Examples were not processing transactions properly.
Temporary fix is to factor in the payload for the commitment

closes #1821 and closes #1766

crates/hotshot/examples/infra/modDA.rs Outdated Show resolved Hide resolved
crates/hotshot/src/demo.rs Outdated Show resolved Hide resolved
@rob-maron rob-maron requested a review from shenkeyao September 28, 2023 00:33
shenkeyao
shenkeyao previously approved these changes Sep 28, 2023
Copy link
Member

@shenkeyao shenkeyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rob-maron rob-maron merged commit dee2dbf into main Sep 28, 2023
4 of 5 checks passed
@rob-maron rob-maron deleted the rm/fix-example-txes branch September 28, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix transaction submission in examples Investigate examples not processing TXes
2 participants