Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove Committable from 3 more types #1789

Merged
merged 3 commits into from
Sep 20, 2023
Merged

chore: remove Committable from 3 more types #1789

merged 3 commits into from
Sep 20, 2023

Conversation

ggutoski
Copy link
Contributor

close #1788

@ggutoski ggutoski requested a review from shenkeyao September 20, 2023 21:07
shenkeyao
shenkeyao approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@shenkeyao shenkeyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggutoski
Copy link
Contributor Author

Tests pass locally. I assume the CI failure is a symptom of our broader CI issues, so I'll merge anyway.

@ggutoski ggutoski merged commit 4a29f8f into main Sep 20, 2023
@ggutoski ggutoski deleted the gg/1788 branch September 20, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenkeyao shenkeyao shenkeyao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

T2.1.3: Remove Committable from type params for VoteMap, VoteAccumulator, VoteType
2 participants
@ggutoski @shenkeyao