revert merge

.github/workflows/build.yml

@@ -1,4 +1,4 @@
-name: Build, Lint, and Test
+name: Build and Test Workflow
 
 on:
   push:
@@ -43,10 +43,6 @@ jobs:
           sudo apt-get install -y protobuf-compiler
           cargo install just
 
-      - name: Run linting
-        run: |
-          just ${{ matrix.just_variants }} lint
-
       - name: Build all crates in workspace
         run: just ${{ matrix.just_variants }} build
 

.github/workflows/lints.yml

@@ -0,0 +1,42 @@
+name: Lints Workflow
+
+on:
+  push:
+    branches:
+      - 'main'
+  pull_request:
+    branches:
+      - 'main'
+      - '*/*'
+  workflow_dispatch:
+
+jobs:
+  lints:
+    runs-on: ubuntu-latest
+    timeout-minutes: 30
+    steps:
+      - uses: styfle/[email protected]
+        name: Cancel Outdated Builds
+        with:
+          all_but_latest: true
+          access_token: ${{ github.token }}
+
+      - name: Install Nix
+        uses: cachix/install-nix-action@v23
+
+      - uses: actions/checkout@v4
+        name: Checkout Repository
+
+      - uses: Swatinem/rust-cache@v2
+        name: Enable Rust Caching
+        with:
+          shared-key: ""
+          prefix-key: lint
+
+      - name: Format Check
+        run: cargo fmt -- --check
+
+      - name: Clippy
+        run: |
+          nix develop -c just async_std lint
+          nix develop -c just tokio lint

Cargo.toml

@@ -52,11 +52,6 @@ either = { version = "1.8" }
 espresso-systems-common = { git = "https://github.com/espressosystems/espresso-systems-common", tag = "0.4.1" }
 ethereum-types = { version = "0.14.1", features = ["impl-serde"] }
 futures = "0.3.28"
-
-# TODO generic-array should not be a direct dependency
-# https://github.com/EspressoSystems/HotShot/issues/1850
-generic-array = { version = "0.14.7", features = ["serde"] }
-
 jf-primitives = { git = "https://github.com/EspressoSystems/jellyfish" }
 jf-relation = { git = "https://github.com/EspressoSystems/jellyfish" }
 jf-utils = { git = "https://github.com/espressosystems/jellyfish" }

crates/hotshot-qc/Cargo.toml

@@ -19,7 +19,7 @@ ark-std = { workspace = true }
 bincode = { workspace = true }
 bitvec = { workspace = true }
 ethereum-types = { workspace = true }
-generic-array = { workspace = true }
+generic-array = "0.14.7"
 hotshot-types = { path = "../types" }
 jf-primitives = { workspace = true }
 jf-relation = { workspace = true }

crates/hotshot-stake-table/Cargo.toml

@@ -16,7 +16,7 @@ bitvec = { workspace = true }
 digest = { workspace = true }
 displaydoc = { version = "0.2.3", default-features = false }
 ethereum-types = { workspace = true }
-generic-array = { workspace = true }
+generic-array = "0.14.7"
 hotshot-types = { path = "../types" }
 jf-primitives = { workspace = true }
 jf-relation = { workspace = true }