fix lint, PartialOrd for Key

EspressoSystems · Oct 26, 2023 · 07e1f86 · 07e1f86
1 parent 3d36e9c
commit 07e1f86
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/crates/hotshot-signature-key/src/bn254/bn254_priv.rs b/crates/hotshot-signature-key/src/bn254/bn254_priv.rs
@@ -56,9 +56,7 @@ impl BLSPrivKey {
 
 impl PartialOrd for BLSPrivKey {
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
-        let self_bytes = &self.priv_key.to_string();
-        let other_bytes = &other.priv_key.to_string();
-        self_bytes.partial_cmp(other_bytes)
+        Some(self.cmp(other))
     }
 }
 

diff --git a/crates/hotshot-signature-key/src/bn254/bn254_pub.rs b/crates/hotshot-signature-key/src/bn254/bn254_pub.rs
@@ -29,9 +29,7 @@ pub struct BLSPubKey {
 
 impl PartialOrd for BLSPubKey {
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
-        let self_bytes = &self.pub_key.to_string();
-        let other_bytes = &other.pub_key.to_string();
-        self_bytes.partial_cmp(other_bytes)
+        Some(self.cmp(other))
     }
 }