New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit highlighter type check #12

Open

nimajalali wants to merge 1 commit into ErwanPigneul:master from nimajalali:patch-1

nimajalali commented Jan 28, 2016

Elastic supports custom highlighters.

We use one internally and this silently fails to add the type to the highlight request.


          Remove explicit highlighter type check

a725b19

Author

nimajalali commented Jan 28, 2016

Looks like I broke the tests by removing t = t.toLowerCase();

I can update the tests to use lowercase highlighter type or I can add the toLowerCase line back in.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet