split quoting behaviour for Snowflake between column identifiers and other identifiers #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…other identifiers
|
What about identifiers with quotes that are also reserved words such as "CASE" in Snowflake? |
Those will remain working, as every identifier still gets quoted. The only change is that column identifiers get quoted in the case they are provided (either inside the mock statement, or returned by the database), rather than getting uppercased by default. |
dcallananILMN
approved these changes
Feb 8, 2024
cdiniz
added
the
safe to test
github-actions
bot
removed
the
safe to test
cdiniz
added
the
safe to test
github-actions
bot
removed
the
safe to test
psousa50
approved these changes
Apr 18, 2024
|
This has been included in release 0.4.2. Once again, thank you very much for your help @dhwdeca! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #141
Default dbt-unit-testing behaviour is to uppercase every identifier on Snowflake.
For dbt configuration this is typically the behaviour we want, but for column identifiers this constraint is too strict.
I suggest keeping the case for column identifiers on Snowflake unchanged, as otherwise the include-missing-columns functionality doesn't work when a database query returns lowercase columns.
This does require a little more diligence in naming the columns in the unit tests themself, but I believe that to be an acceptable requirement.