Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated parametrization #13

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions hydra_plugins/hydra_orion_sweeper/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,16 +85,10 @@ class OrionSweeperConf:

storage: StorageConf = StorageConf()

# deprecated, use params instead
parametrization: Optional[Dict[str, Any]] = None

# Search space (Optuna & default)
# See `Search Space <https://orion.readthedocs.io/en/stable/user/searchspace.html>`_
params: Optional[Dict[str, Any]] = None

# Note: Ax space is configured as hydra.sweeper.ax.ax_config.params
# which is a bit too convoluted for us to support


ConfigStore.instance().store(
group="hydra/sweeper",
Expand Down
19 changes: 0 additions & 19 deletions hydra_plugins/hydra_orion_sweeper/orion_sweeper.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
Implements a sweeper plugin for Orion
"""
from typing import List, Optional
from warnings import warn

from hydra import TaskFunction
from hydra.plugins.sweeper import Sweeper
Expand All @@ -22,28 +21,10 @@ def __init__(
worker: WorkerConf,
algorithm: AlgorithmConf,
storage: StorageConf,
parametrization: Optional[DictConfig],
params: Optional[DictConfig],
):
from .implementation import OrionSweeperImpl

# >>> Remove with Issue #8
if parametrization is not None and params is None:
warn(
"`hydra.sweeper.orion.parametrization` is deprecated;"
"use `hydra.sweeper.params` instead",
DeprecationWarning,
)
params = parametrization

elif parametrization is not None and params is not None:
warn(
"Both `hydra.sweeper.orion.parametrization` and `hydra.sweeper.params` are defined;"
"using `hydra.sweeper.params`",
DeprecationWarning,
)
# <<<

if params is None:
params = dict()

Expand Down
64 changes: 0 additions & 64 deletions tests/test_warnings.py

This file was deleted.