Fix duplicate definition of mysql_connect by renaming local version t… #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o mysql_connect_fdw. When compiling against MariaDB 10.23.1 on Debian the definition of mysql_connect in the mysql_fdw source conflicts with the definition in mysql.h; simple workaround with a rename.
|
@jeevanchalke, any decision? It's also my problem with MariaDB. |
|
Looks reasonable. We will take it further. Thanks. |
jeevanchalke
added a commit
that referenced
this pull request
Feb 15, 2023
On MariaDB, mysql.h do have function named mysql_connect() conflicting with our version. So rename it. Reported on GitHub through pull request #145 by Glyn Astill (glynastill). Another user, Михаил (mkgrgis), also requested these changes. Glyn Astill, revised by Jeevan Chalke.
|
Pushed revised patch. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o mysql_connect_fdw.
When compiling against MariaDB 10.23.1 on Debian the definition of mysql_connect in the mysql_fdw source conflicts with the definition in mysql.h; simple workaround with a rename.