refactor webview with new package to support header override #1731
+319
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahmood74
requested changes
Nov 21, 2024
| List<HeaderOverrideRule> parseHeaderRules(YamlList yamlList) { | ||
| return yamlList.map((rule) { | ||
| Map<String, String> headers = {}; | ||
| (rule['headers'] as YamlMap).forEach((key, value) { |
There was a problem hiding this comment.
by assuming it's a YamlMap, we make it impossible for someone to set this value in js. Please just use Map
| @@ -17,6 +17,7 @@ import 'package:flutter/material.dart'; | |||
| class WebViewState extends EWidgetState<EnsembleWebView> { | |||
| final IFrameElement _iframeElement = IFrameElement(); | |||
| HtmlElementView? htmlView; | |||
| final String viewId = 'iframeElement-${DateTime.now().millisecondsSinceEpoch}'; | |||
There was a problem hiding this comment.
why make it a unique viewId, is it causing memory leaks?
| (int viewId) => _iframeElement, | ||
| ); | ||
|
|
||
| return HtmlElementView( | ||
| key: UniqueKey(), | ||
| viewType: 'iframeElement', | ||
| viewType: viewId, | ||
| ); |
There was a problem hiding this comment.
we should add a dispose method here and dispose off the htmlView and iframeElement. That should get rid of the memory leak
|
|
||
| // Set cookie for main domain | ||
| await widget.controller.cookieManager.setCookie( | ||
| url: Uri.parse('https://$cookieDomain'), |
There was a problem hiding this comment.
we can't assume that it's always https. Please get the protocol from the url as well and don't hardcode it
| final cookieDomain = cookieData['domain'] ?? mainUrl.host; | ||
|
|
||
| await widget.controller.cookieManager.setCookie( | ||
| url: Uri.parse('https://$cookieDomain'), |
kmahmood74
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced 'https://pub.dev/packages/webview_flutter' with 'https://pub.dev/packages/flutter_inappwebview' to support headers override.
Added following new properties:
Test with following android and web, things worked fine by my end, iOS still needs some testing.
kpnwebview.mp4
webview.mp4