Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] expose properties and fix some bugs in chat widget. #1727

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[WIP] expose properties and fix some bugs in chat widget. #1727

wants to merge 5 commits into from
+265 −131

Conversation

TheNoumanDev
Copy link
Member

@TheNoumanDev TheNoumanDev commented Nov 18, 2024 •
edited
Loading

Following things done:

  • fixed the bug with initialMessages not handling and building inlineWidgets. now it is building the widgets.
  • fixed the bug, with whenever we are coming back to screen, initialMessages, used to load again and again as shown below, fixed it.
  • exposed some styling properties to make it compatible with the theming perspective,
  • fixed the bad state error shown in the picture, that was happening, if we have any widget in chat, if its all text, then it was working fine, so basically the reference was being static and when we used to come back, it used to break down, so I removed build widgets in dispose and rebuild them when getting navigate to back to chat screen.

SS
image description
image description
image description

@TheNoumanDev TheNoumanDev marked this pull request as ready for review November 22, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snehmehta snehmehta snehmehta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheNoumanDev @snehmehta