Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added cache in API call #918

Merged
merged 7 commits into from
Nov 27, 2024
Merged

Conversation

sagardspeed2
Copy link
Contributor

@sagardspeed2 sagardspeed2 commented Nov 22, 2024

Describe your changes

fix added cache support in API trigger

Screenshots [Optional]

Issue ticket number and link

Closes #350

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests
  • I have added a changeset pnpm changeset add
  • I have added example usage in the kitchen sink app

@sagardspeed2 sagardspeed2 self-assigned this Nov 22, 2024
Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: a3c23f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@ensembleui/react-framework Patch
@ensembleui/react-kitchen-sink Patch
@ensembleui/react-runtime Patch
@ensembleui/react-preview Patch
@ensembleui/react-starter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Visit the preview URL for this PR (updated for commit a3c23f9):

https://react-kitchen-sink-dev--pr918-350-added-cache-supp-abpzdw6f.web.app

(expires Wed, 04 Dec 2024 04:14:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9

Copy link
Contributor

@evshi evshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add caching to the other invocation for executeCode.

packages/framework/src/api/data.ts Outdated Show resolved Hide resolved
packages/framework/src/api/data.ts Outdated Show resolved Hide resolved
packages/framework/src/shared/models.ts Outdated Show resolved Hide resolved
@sagardspeed2 sagardspeed2 merged commit ec9d081 into main Nov 27, 2024
3 checks passed
@sagardspeed2 sagardspeed2 deleted the 350-added-cache-support-in-api branch November 27, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize graphql query state
2 participants