Break out protocol library

[zml2008]

This allows WorldEdit to use this library as a JiJ'd mod, which avoids issues using integrated server in 1.20.6 caused by registering the same packet with two types (one from WE, the other from WECUI).

[zml2008]

no, we already have a 1.21 branch at https://github.com/EngineHub/WorldEditCUI/tree/mc/1.21, not sure why someone else decided to do one at random.

[mk-pmb]

Thanks! Probably because it was hard to discover. I should have just looked at the branch list. Probably the locked thread gave me a false impression of maintainers not being interested in updating. I'll have a look and re-evaluate.

Edit: I remember now. I was convinced that there was no 1.21 version because first Prism Launcher couldn't find it, and then the most related thread was locked, seemlingly because of users discussing stopgap solutions for 1.21 compatibility. As if that was a banned topic here. I wish someone had explained the thread close right before doing so.

[mk-pmb]

I tried the 1.21 branch. It works, but as its ancestry suggests, it suffers from the double packet type registration problem in single player. So my new task is to merge this here pull request with the 1.21 branch, ideally with an intermediate step that merges #109 if you would like.
My current obstacle is the same as before: Splitting the big renames. How much would you like to be involved in helping with that (as described above)?

Update / opportunity for comment: While splitting out the renames, I discovered that worldeditcui-protocol-*/build.gradle.kts are identical in the "rearrange" commit. I found that they will be modified later, so my tendency is to make a separate commit for them where I explain why we temporarily make identical copies rather than using symlinks or includes.

[zml2008]

Don't waste your time, the obstacle is setting up publishing and updating WE more than anything on the cui side, we can just rebase whenever that happens

…

On Sun, Aug 25, 2024, at 22:54, M.K. wrote: I tried the 1.21 branch. It works, but as its ancestry suggests, it suffers from the double packet type registration problem in single player. So my new task is to merge this here pull request with the 1.21 branch, ideally with an intermediate step that merges #109 <#109> if you would like. My current obstacle is the same as before: Splitting the big renames. How much would you like to be involved in helping with that (as described above)? — Reply to this email directly, view it on GitHub <#113 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEZSZGSTDEZ4FCJ4Q55J6TZTK7I7AVCNFSM6AAAAABJNIAADKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBZGM3TOOJSGY>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[mk-pmb]

You mean, a merge here wouldn't solve the issue? It seems I'm missing something important then. Ok, where shall I invest my effort?

[mk-pmb]

Usually I'd edit, but seeing you reply by email you may miss that: I found your WE pull request #2554 "Use WECUI protocol library" in draft status.
The second commit sounds like it should rather be an amend commit to the previous; shall I clean that up?

Or does "setting up publishing and updating WE" mean to set up a build pipeline for your pull request? I have that for my own branch and also made one for the feat/cui-proto-lib branch but that currently fails with

> Could not resolve all files for configuration ':worldedit-fabric:modImplementation'.
   > Could not find org.enginehub.worldeditcui:worldeditcui-protocol-fabric:1.20.6+01-SNAPSHOT.

Is that something I should try to fix? I'm a total noob to fabric, but I could try anyway.