Deprecate bundled item data #2514
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldedit-core/src/main/java/com/sk89q/worldedit/world/registry/BundledItemRegistry.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/sk89q/worldedit/world/registry/BundledItemData.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/sk89q/worldedit/world/item/ItemType.java
Outdated
Show resolved
Hide resolved
worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitItemRegistry.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/sk89q/worldedit/world/registry/BundledItemData.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/sk89q/worldedit/world/registry/BundledItemRegistry.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/sk89q/worldedit/world/registry/ItemRegistry.java
Show resolved
Hide resolved
worldedit-core/src/main/java/com/sk89q/worldedit/world/registry/PassthroughItemMaterial.java
Show resolved
Hide resolved
worldedit-core/src/main/java/com/sk89q/worldedit/world/registry/SimpleItemMaterial.java
Show resolved
Hide resolved
me4502
force-pushed
the
chore/deprecate-bundled-item-data
branch
from
0c91194
to
9834d08
Compare
me4502
force-pushed
the
chore/deprecate-bundled-item-data
branch
from
9834d08
to
873b2ed
Compare
octylFractal
reviewed
Nov 4, 2024
| @@ -65,6 +65,7 @@ static URL loadRegistry(String name) throws IOException { | |||
| } | |||
|
|
|||
| private final BundledBlockRegistry blockRegistry = new BundledBlockRegistry(); | |||
| @SuppressWarnings("removal") | |||
There was a problem hiding this comment.
Shouldn't we deprecate this field / the related getters in this class?
There was a problem hiding this comment.
we can deprecate the field, but we cannot deprecate the getter currently because that propagates it to all classes that extend this, and would lead to non-deprecated methods getting marked as deprecated.
we currently can't remove this from the inheritance tree, so it's not really an option to deprecate this currently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the concept of bundled item data, as well as the concept of "item material". This was added but never actually used. It's not very mod-compatible, and also requires storing increasingly large numbers of JSON files within the repo and jar files.
Due to the fact that WorldEdit never uses these at all, and that the bundled item registry is loaded when first accessed, this means we can remove the call to actually load it from WorldEdit. If something does happen to be using this deprecated API, it'll trigger it to be loaded upon first access.