Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same name attribute for every radio within the same radio-group #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renaudleo
Copy link

What Changed & Why

The radio widget uses a name attribute, but the radio-group widget doesn't actually pass that param to radio, so radio buttons in a radio group don't have any name attribute.

Testing

List step-by-step how to test the changes.

  • Use a radio-group widget
  • Inspect the radio input html
  • It should now have a name attribute 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants